Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 690053002: Cleanup conversion that the new NDK compiler tries to over optimize. (Closed)

Created:
6 years, 1 month ago by djsollen
Modified:
6 years, 1 month ago
Reviewers:
jvanverth1, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Cleanup conversion that the new NDK compiler tries to over optimize. This allows us to upgrade to NDK r10c as the dftext gm no longer fails when compiled with -O2. Committed: https://skia.googlesource.com/skia/+/058f01eb688dfabf5ebc89348872f4eebb9c173a

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M src/gpu/GrDistanceFieldTextContext.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 4 chunks +3 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
djsollen
6 years, 1 month ago (2014-10-30 16:24:53 UTC) #2
jvanverth1
We missed one: https://codereview.chromium.org/690053002/diff/1/src/gpu/GrDistanceFieldTextContext.cpp File src/gpu/GrDistanceFieldTextContext.cpp (right): https://codereview.chromium.org/690053002/diff/1/src/gpu/GrDistanceFieldTextContext.cpp#newcode345 src/gpu/GrDistanceFieldTextContext.cpp:345: if (!this->appendGlyph(GrGlyph::Pack(glyph.getGlyphID(), There is another call ...
6 years, 1 month ago (2014-10-30 16:37:16 UTC) #3
djsollen
ok, the second patch set fixes that call site as well.
6 years, 1 month ago (2014-10-30 16:52:11 UTC) #4
jvanverth1
lgtm
6 years, 1 month ago (2014-10-30 17:04:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/690053002/20001
6 years, 1 month ago (2014-10-30 17:10:55 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:54:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 058f01eb688dfabf5ebc89348872f4eebb9c173a

Powered by Google App Engine
This is Rietveld 408576698