Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1142)

Issue 689993003: Remove Extra call to CloseProcessHandle (Closed)

Created:
6 years, 1 month ago by csharp
Modified:
6 years, 1 month ago
Reviewers:
waffles, Sorin Jianu, MAD
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove Extra call to CloseProcessHandle WaitForExitCode already handles closing the processes handle, so we shouldn't be double closing it. TBR=waffles BUG=428957 Committed: https://crrev.com/73eab03629de46c6d4b225b59aa4da111fadd729 Cr-Commit-Position: refs/heads/master@{#302208}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/component_updater/sw_reporter_installer_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
csharp
6 years, 1 month ago (2014-10-30 20:40:31 UTC) #2
MAD
LGTM, I think we should TBR this to an OWNER and commit it now... Thanks! ...
6 years, 1 month ago (2014-10-30 23:42:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689993003/1
6 years, 1 month ago (2014-10-31 00:46:33 UTC) #7
Sorin Jianu
lgtm neat!
6 years, 1 month ago (2014-10-31 00:55:53 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 01:29:46 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 01:30:19 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73eab03629de46c6d4b225b59aa4da111fadd729
Cr-Commit-Position: refs/heads/master@{#302208}

Powered by Google App Engine
This is Rietveld 408576698