Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 689993002: Add default allowed value of Ask for Push Notifications. (Closed)

Created:
6 years, 1 month ago by Finnur
Modified:
6 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add default allowed value of Ask for Push Notifications. Push Notifications not only support Ask already, it is the default value, so this should match that reality. BUG=425698 Committed: https://crrev.com/6a6414165fd098d1df8d4c5e5ddf74d2648282dc Cr-Commit-Position: refs/heads/master@{#302136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/content_settings/core/browser/host_content_settings_map.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Finnur
6 years, 1 month ago (2014-10-30 14:41:59 UTC) #2
Bernhard Bauer
lgtm
6 years, 1 month ago (2014-10-30 16:44:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689993002/1
6 years, 1 month ago (2014-10-30 18:45:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 19:54:40 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 19:56:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a6414165fd098d1df8d4c5e5ddf74d2648282dc
Cr-Commit-Position: refs/heads/master@{#302136}

Powered by Google App Engine
This is Rietveld 408576698