Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 689943003: Remove libxml dependency from Sky (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
jamesr, esprehn, ojan
CC:
ojan, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M sky/engine/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
abarth-chromium
6 years, 1 month ago (2014-11-08 01:16:31 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-11-08 01:42:54 UTC) #3
abarth-chromium
Committed patchset #1 (id:1) manually as 47aaf74900e66dc6ec6f9cd86d6810b0a7aa471a (presubmit successful).
6 years, 1 month ago (2014-11-08 01:47:47 UTC) #4
ojan
amazing
6 years, 1 month ago (2014-11-08 01:52:23 UTC) #6
abarth-chromium
6 years, 1 month ago (2014-11-08 01:58:39 UTC) #7
Message was sent while issue was closed.
On 2014/11/08 at 01:52:23, ojan wrote:
> amazing

We actually cut the dependency a while ago.  I just forgot to remove it from the
build system.

Powered by Google App Engine
This is Rietveld 408576698