Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 689933002: Corrected serialization of ::cue() functions. (Closed)

Created:
6 years, 1 month ago by rune
Modified:
6 years, 1 month ago
Reviewers:
andersr, Timothy Loh
CC:
blink-reviews, blink-reviews-css, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Corrected serialization of ::cue() functions. The selectorList argument of ::cue() functions were just dropped. Serialization of that list is now done. The explicit universal tag "*" is not correct per CSSOM spec, but I didn't address that in this CL. Besides, that also affects a bunch of the custom pseudo elements. Nothing changed here. Also removed a bunch of unnecessary CSSSelector:: prefixing. R=timloh@chromium.org,andersr@opera.com BUG=428696 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184767

Patch Set 1 #

Total comments: 1

Patch Set 2 : Additional test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -24 lines) Patch
A LayoutTests/fast/css/cue-serialize.html View 1 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/cue-serialize-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/css/CSSSelector.cpp View 6 chunks +35 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
rune
6 years, 1 month ago (2014-10-30 13:13:09 UTC) #1
andersr
lgtm https://codereview.chromium.org/689933002/diff/1/LayoutTests/fast/css/cue-serialize.html File LayoutTests/fast/css/cue-serialize.html (right): https://codereview.chromium.org/689933002/diff/1/LayoutTests/fast/css/cue-serialize.html#newcode14 LayoutTests/fast/css/cue-serialize.html:14: shouldBe("rules[1].selectorText", "'*::cue(c)'"); Perhaps add a test with multiple ...
6 years, 1 month ago (2014-10-31 10:11:29 UTC) #2
rune
On 2014/10/31 at 10:11:29, andersr wrote: > lgtm > > https://codereview.chromium.org/689933002/diff/1/LayoutTests/fast/css/cue-serialize.html > File LayoutTests/fast/css/cue-serialize.html (right): ...
6 years, 1 month ago (2014-10-31 12:45:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689933002/20001
6 years, 1 month ago (2014-10-31 12:47:26 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-31 12:47:29 UTC) #7
rune
On 2014/10/31 at 12:47:29, commit-bot wrote: > No LGTM from a valid reviewer yet. Only ...
6 years, 1 month ago (2014-10-31 13:03:15 UTC) #8
Timothy Loh
On 2014/10/31 13:03:15, rune wrote: > On 2014/10/31 at 12:47:29, commit-bot wrote: > > No ...
6 years, 1 month ago (2014-10-31 22:58:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689933002/20001
6 years, 1 month ago (2014-11-01 05:45:14 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 06:48:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184767

Powered by Google App Engine
This is Rietveld 408576698