Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 68993005: Mojo: More plumbing to support sending handles over MessagePipes. (Closed)

Created:
7 years, 1 month ago by viettrungluu
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: More plumbing to support sending handles over MessagePipes. R=darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -42 lines) Patch
M mojo/system/channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/system/dispatcher.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/system/dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/local_message_pipe_endpoint.h View 1 chunk +8 lines, -4 lines 0 comments Download
M mojo/system/local_message_pipe_endpoint.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M mojo/system/message_pipe.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/system/message_pipe.cc View 5 chunks +12 lines, -7 lines 0 comments Download
M mojo/system/message_pipe_dispatcher.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M mojo/system/message_pipe_endpoint.h View 4 chunks +13 lines, -4 lines 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 3 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
This is pretty trivial -- just passing vectors of dispatchers down to lower levels -- ...
7 years, 1 month ago (2013-11-12 01:21:13 UTC) #1
darin (slow to review)
LGTM
7 years, 1 month ago (2013-11-12 05:14:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/68993005/1
7 years, 1 month ago (2013-11-12 06:01:57 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 1 month ago (2013-11-12 06:47:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/68993005/1
7 years, 1 month ago (2013-11-12 08:22:14 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-12 10:32:11 UTC) #6
Message was sent while issue was closed.
Change committed as 234475

Powered by Google App Engine
This is Rietveld 408576698