Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/app_installer/app_installer.gypi

Issue 689903003: [app_installer] Refactor and add app_installer_unittests target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync and rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/all.gyp ('k') | chrome/app_installer/win/app_installer_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app_installer/app_installer.gypi
diff --git a/chrome/app_installer/app_installer.gypi b/chrome/app_installer/app_installer.gypi
index f83df523ba6cf1e253922af42c24054a2e1468b1..dd063548e178cf1cc181378c221694cbf360ef7e 100644
--- a/chrome/app_installer/app_installer.gypi
+++ b/chrome/app_installer/app_installer.gypi
@@ -6,11 +6,9 @@
'conditions': [
['OS=="win"', {
'targets': [
- # TODO(jackhou): Add a version resource (using
- # version_resource_rules.gypi).
{
- 'target_name': 'app_installer',
- 'type': 'executable',
+ 'target_name': 'app_installer_util',
+ 'type': 'static_library',
'dependencies': [
'installer_util',
'installer_util_strings',
@@ -24,6 +22,24 @@
'<(INTERMEDIATE_DIR)',
],
'sources': [
+ 'win/app_installer_util.cc',
+ 'win/app_installer_util.h',
+ ],
+ },
+ # TODO(jackhou): Add a version resource (using
+ # version_resource_rules.gypi).
+ {
+ 'target_name': 'app_installer',
+ 'type': 'executable',
+ 'dependencies': [
+ 'app_installer_util',
+ '../base/base.gyp:base',
+ ],
+ 'include_dirs': [
+ '..',
+ '<(INTERMEDIATE_DIR)',
+ ],
+ 'sources': [
'win/app_installer_main.cc',
],
'msvs_settings': {
@@ -37,6 +53,30 @@
},
},
},
+ {
+ 'target_name': 'app_installer_unittests',
+ 'type': 'executable',
+ 'dependencies': [
+ 'app_installer_util',
+ '../base/base.gyp:base',
+ '../base/base.gyp:run_all_unittests',
+ '../testing/gtest.gyp:gtest',
+ ],
+ 'include_dirs': [
+ '..',
+ '<(INTERMEDIATE_DIR)',
+ ],
+ 'sources': [
+ 'win/app_installer_util_unittest.cc',
+ ],
+ 'msvs_settings': {
+ 'VCManifestTool': {
+ 'AdditionalManifestFiles': [
+ 'app_installer/win/app_installer.exe.manifest',
+ ],
+ },
+ },
+ },
],
}],
],
« no previous file with comments | « build/all.gyp ('k') | chrome/app_installer/win/app_installer_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698