[app_installer] Refactor and add app_installer_unittests target.

chrome/app_installer/app_installer.gypi

Index: chrome/app_installer/app_installer.gypi
diff --git a/chrome/app_installer/app_installer.gypi b/chrome/app_installer/app_installer.gypi
index f83df523ba6cf1e253922af42c24054a2e1468b1..dd063548e178cf1cc181378c221694cbf360ef7e 100644
--- a/chrome/app_installer/app_installer.gypi
+++ b/chrome/app_installer/app_installer.gypi
@@ -6,11 +6,9 @@
   'conditions': [
     ['OS=="win"', {
       'targets': [
-        # TODO(jackhou): Add a version resource (using
-        # version_resource_rules.gypi).
         {
-          'target_name': 'app_installer',
-          'type': 'executable',
+          'target_name': 'app_installer_util',
+          'type': 'static_library',
           'dependencies': [
             'installer_util',
             'installer_util_strings',
@@ -24,6 +22,24 @@
             '<(INTERMEDIATE_DIR)',
           ],
           'sources': [
+            'win/app_installer_util.cc',
+            'win/app_installer_util.h',
+          ],
+        },
+        # TODO(jackhou): Add a version resource (using
+        # version_resource_rules.gypi).
+        {
+          'target_name': 'app_installer',
+          'type': 'executable',
+          'dependencies': [
+            'app_installer_util',
+            '../base/base.gyp:base',
+          ],
+          'include_dirs': [
+            '..',
+            '<(INTERMEDIATE_DIR)',
+          ],
+          'sources': [
             'win/app_installer_main.cc',
           ],
           'msvs_settings': {
@@ -37,6 +53,30 @@
             },
           },
         },
+        {
+          'target_name': 'app_installer_unittests',

[grt (UTC plus 2), 2014/11/07 03:13:36]

in the new world, i think you just need to add this new test to
https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/chro...
and chromium.win.json for it to run on the tryservers and the waterfall. give
that a shot in this CL and see if it runs if you send up a tryjob.

[jackhou1, 2014/11/07 05:37:52]

Hmm, adding it to chromium_trybot.json didn't cause it to be run on a try job,
but adding it to chromium.win.json did. In any case, seems to be working. 

+          'type': 'executable',
+          'dependencies': [
+            'app_installer_util',
+            '../base/base.gyp:base',
+            '../base/base.gyp:run_all_unittests',
+            '../testing/gtest.gyp:gtest',
+          ],
+          'include_dirs': [
+            '..',
+            '<(INTERMEDIATE_DIR)',
+          ],
+          'sources': [
+            'win/app_installer_util_unittest.cc',
+          ],
+          'msvs_settings': {
+            'VCManifestTool': {
+              'AdditionalManifestFiles': [
+                'app_installer/win/app_installer.exe.manifest',
+              ],
+            },
+          },
+        },
       ],
     }],
   ],