[app_installer] Refactor and add app_installer_unittests target.

[app_installer] Refactor and app_installer_unittests target.

This pulls some code out of app_installer_main into app_installer_util
and adds a new app_installer_unittests target.

BUG=430790
Committed: https://crrev.com/9f3e1fba3e060a0e7317ea1231a10a21afaaa39e
Cr-Commit-Position: refs/heads/master@{#303955}

[jackhou1, 2014-11-06 06:00:34]

jackhou@chromium.org changed reviewers:
+ grt@chromium.org

[jackhou1, 2014-11-06 06:00:35]

grt, could you take a look?

In particular, is this the right setup gyp-wise? Do I need to add the target
somewhere to have it actually be run?

There's just a basic test in app_installer_unittests.cc for now. I'll add more
tests as I make further changes to app_installer.

[grt (UTC plus 2), 2014-11-07 03:13:36]

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/app_ins...
File chrome/app_installer/app_installer.gypi (right):

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/app_ins...
chrome/app_installer/app_installer.gypi:57: 'target_name':
'app_installer_unittests',
in the new world, i think you just need to add this new test to
https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/chro...
and chromium.win.json for it to run on the tryservers and the waterfall. give
that a shot in this CL and see if it runs if you send up a tryjob.

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
File chrome/app_installer/win/app_installer_util.h (right):

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
chrome/app_installer/win/app_installer_util.h:29: std::string GetTag(const
base::FilePath& file_name_path);
#include <string>

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
chrome/app_installer/win/app_installer_util.h:36: std::map<std::string,
std::string>* parsed_pairs);
#include <map>

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
File chrome/app_installer/win/app_installer_util_unittest.cc (right):

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
chrome/app_installer/win/app_installer_util_unittest.cc:12:
std::map<std::string, std::string> parsed_pairs;
#include <map>
#include <string>

[jackhou1, 2014-11-07 05:37:53]

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/app_ins...
File chrome/app_installer/app_installer.gypi (right):

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/app_ins...
chrome/app_installer/app_installer.gypi:57: 'target_name':
'app_installer_unittests',
On 2014/11/07 03:13:36, grt wrote:
> in the new world, i think you just need to add this new test to
>
https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/chro...
> and chromium.win.json for it to run on the tryservers and the waterfall. give
> that a shot in this CL and see if it runs if you send up a tryjob.

Hmm, adding it to chromium_trybot.json didn't cause it to be run on a try job,
but adding it to chromium.win.json did. In any case, seems to be working.

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
File chrome/app_installer/win/app_installer_util.h (right):

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
chrome/app_installer/win/app_installer_util.h:29: std::string GetTag(const
base::FilePath& file_name_path);
On 2014/11/07 03:13:36, grt wrote:
> #include <string>

Done.

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
chrome/app_installer/win/app_installer_util.h:36: std::map<std::string,
std::string>* parsed_pairs);
On 2014/11/07 03:13:36, grt wrote:
> #include <map>

Done.

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
File chrome/app_installer/win/app_installer_util_unittest.cc (right):

https://codereview.chromium.org/689903003/diff/1/chrome/app_installer/win/app...
chrome/app_installer/win/app_installer_util_unittest.cc:12:
std::map<std::string, std::string> parsed_pairs;
On 2014/11/07 03:13:36, grt wrote:
> #include <map>
> #include <string>

Done.

[grt (UTC plus 2), 2014-11-07 18:54:49]

grt@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[grt (UTC plus 2), 2014-11-07 18:54:49]

Looks okay to me. +phajdan.jr to comment on the buildbot configs and new test.

[jackhou1, 2014-11-12 02:48:41]

phajdan, ping

Please take a look at testing/buildbot/

[Paweł Hajdan Jr., 2014-11-12 14:25:33]

LGTM

[jackhou1, 2014-11-13 00:31:51]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-11-13 00:32:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/689903003/80001

[commit-bot: I haz the power, 2014-11-13 01:32:43]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-13 01:33:19]

Patchset 5 (id:??) landed as
https://crrev.com/9f3e1fba3e060a0e7317ea1231a10a21afaaa39e
Cr-Commit-Position: refs/heads/master@{#303955}