Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: chrome/browser/chromeos/policy/enrollment_status_chromeos.h

Issue 689903002: Add explicit numerical ids to EnrollmentStatus::Status enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove STATUS_COUNT to fix compilation. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/policy/enrollment_status_chromeos.h
diff --git a/chrome/browser/chromeos/policy/enrollment_status_chromeos.h b/chrome/browser/chromeos/policy/enrollment_status_chromeos.h
index 644e48e5e81d6412f3ea39fc83cded4e890072c3..dc0ac999eec067b7493d023d03d3ab37139d41fc 100644
--- a/chrome/browser/chromeos/policy/enrollment_status_chromeos.h
+++ b/chrome/browser/chromeos/policy/enrollment_status_chromeos.h
@@ -15,23 +15,27 @@ namespace policy {
// codes received from the involved components.
class EnrollmentStatus {
public:
- // Enrollment status codes.
+ // Enrollment status codes. Do not change the order or the meaning of the
+ // existing codes to preserve the interpretability of old logfiles.
enum Status {
- STATUS_SUCCESS, // Enrollment succeeded.
- STATUS_NO_STATE_KEYS, // Server-backed state keys unavailable.
- STATUS_REGISTRATION_FAILED, // DM registration failed.
- STATUS_REGISTRATION_BAD_MODE, // Bad device mode.
- STATUS_ROBOT_AUTH_FETCH_FAILED, // API OAuth2 auth code failure.
- STATUS_ROBOT_REFRESH_FETCH_FAILED, // API OAuth2 refresh token failure.
- STATUS_ROBOT_REFRESH_STORE_FAILED, // Failed to store API OAuth2 token.
- STATUS_POLICY_FETCH_FAILED, // DM policy fetch failed.
- STATUS_VALIDATION_FAILED, // Policy validation failed.
- STATUS_LOCK_ERROR, // Cryptohome failed to lock the device.
- STATUS_LOCK_TIMEOUT, // Timeout while waiting for the lock.
- STATUS_LOCK_WRONG_USER, // Locked to different domain.
- STATUS_STORE_ERROR, // Failed to store the policy.
- STATUS_STORE_TOKEN_AND_ID_FAILED, // Failed to store DM token and device
- // ID.
+ STATUS_SUCCESS = 0, // Enrollment succeeded.
+ STATUS_NO_STATE_KEYS = 1, // Server-backed state keys
+ // unavailable.
+ STATUS_REGISTRATION_FAILED = 2, // DM registration failed.
+ STATUS_REGISTRATION_BAD_MODE = 3, // Bad device mode.
+ STATUS_ROBOT_AUTH_FETCH_FAILED = 4, // API OAuth2 auth code failure.
+ STATUS_ROBOT_REFRESH_FETCH_FAILED = 5, // API OAuth2 refresh token failure.
+ STATUS_ROBOT_REFRESH_STORE_FAILED = 6, // Failed to store API OAuth2 token.
+ STATUS_POLICY_FETCH_FAILED = 7, // DM policy fetch failed.
+ STATUS_VALIDATION_FAILED = 8, // Policy validation failed.
+ STATUS_LOCK_ERROR = 9, // Cryptohome failed to lock the
+ // device.
+ STATUS_LOCK_TIMEOUT = 10, // Timeout while waiting for the
+ // lock.
+ STATUS_LOCK_WRONG_USER = 11, // Locked to different domain.
+ STATUS_STORE_ERROR = 12, // Failed to store the policy.
+ STATUS_STORE_TOKEN_AND_ID_FAILED = 13, // Failed to store DM token and
+ // device ID.
};
// Helpers for constructing errors for relevant cases.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698