Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 689903002: Add explicit numerical ids to EnrollmentStatus::Status enum. (Closed)

Created:
6 years, 1 month ago by Thiemo Nagel
Modified:
6 years, 1 month ago
Reviewers:
pastarmovj
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add explicit numerical ids to EnrollmentStatus::Status enum. This makes it easier to interpret log messages that contain enum values. BUG=none Committed: https://crrev.com/9477d5b04dc373288d48268d387658a35a01086d Cr-Commit-Position: refs/heads/master@{#302091}

Patch Set 1 #

Patch Set 2 : Improve comment after offline discussion with Julian. #

Total comments: 2

Patch Set 3 : Remove STATUS_COUNT to fix compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/chromeos/policy/enrollment_status_chromeos.h View 1 2 1 chunk +20 lines, -16 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Thiemo Nagel
Hi Julian, could you please take a look at this small improvement? Thank you! Thiemo
6 years, 1 month ago (2014-10-30 12:23:23 UTC) #2
Thiemo Nagel
Updated as discussed. Could you please take another look? Thank you! Thiemo
6 years, 1 month ago (2014-10-30 14:03:50 UTC) #3
pastarmovj
https://codereview.chromium.org/689903002/diff/20001/chrome/browser/chromeos/policy/enrollment_status_chromeos.h File chrome/browser/chromeos/policy/enrollment_status_chromeos.h (right): https://codereview.chromium.org/689903002/diff/20001/chrome/browser/chromeos/policy/enrollment_status_chromeos.h#newcode39 chrome/browser/chromeos/policy/enrollment_status_chromeos.h:39: STATUS_COUNT = 14, // Not a status code. Thinking ...
6 years, 1 month ago (2014-10-30 14:08:50 UTC) #4
Thiemo Nagel
Another try: As it seems that adding a "last" entry creates more problems than it ...
6 years, 1 month ago (2014-10-30 14:24:51 UTC) #5
pastarmovj
lgtm
6 years, 1 month ago (2014-10-30 14:39:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689903002/40001
6 years, 1 month ago (2014-10-30 15:59:53 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 16:41:49 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 16:42:29 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9477d5b04dc373288d48268d387658a35a01086d
Cr-Commit-Position: refs/heads/master@{#302091}

Powered by Google App Engine
This is Rietveld 408576698