chrome/browser/extensions/extension_commands_global_registry_apitest.cc - Issue 689883004: Disable flaky test GlobalCommandsApiTest.GlobalDuplicatedMediaKey

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_commands_global_registry_apitest.cc

Issue 689883004: Disable flaky test GlobalCommandsApiTest.GlobalDuplicatedMediaKey (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_commands_global_registry_apitest.cc

diff --git a/chrome/browser/extensions/extension_commands_global_registry_apitest.cc b/chrome/browser/extensions/extension_commands_global_registry_apitest.cc

index cbe6281a177f9d9cd376afd98422f73d1699c0a9..ff8fbb7cbe7fda8f86e85d187cce69e4e3006a34 100644

--- a/chrome/browser/extensions/extension_commands_global_registry_apitest.cc

+++ b/chrome/browser/extensions/extension_commands_global_registry_apitest.cc

@@ -174,7 +174,8 @@ IN_PROC_BROWSER_TEST_F(GlobalCommandsApiTest, GlobalCommand) {

#if defined(OS_WIN)

// Feature only fully implemented on Windows, other platforms coming.

// TODO(smus): On mac, SendKeyPress must first support media keys.

-#define MAYBE_GlobalDuplicatedMediaKey GlobalDuplicatedMediaKey

+// Test occasionally times out on Windows. http://crbug.com/428813

+#define MAYBE_GlobalDuplicatedMediaKey DISABLED_GlobalDuplicatedMediaKey

#else

#define MAYBE_GlobalDuplicatedMediaKey DISABLED_GlobalDuplicatedMediaKey

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »