Issue 689883003: Fix bug in optimization of Uint32LessThan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 689883003: Fix bug in optimization of Uint32LessThan. (Closed)

Created:
6 years, 1 month ago by titzer

Modified:
6 years, 1 month ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix bug in optimization of Uint32LessThan. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25023

Patch Set 1 #

Patch Set 2 : Add TODO(turbofan) #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -6 lines)			Patch
M	src/compiler/machine-operator-reducer.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
A	test/mjsunit/asm/uint32-less-than-shift.js	View		1 chunk	+61 lines, -0 lines	0 comments	Download
M	test/unittests/compiler/machine-operator-reducer-unittest.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

titzer

Committed patchset #2 (id:20001) manually as 25023 (presubmit successful).

6 years, 1 month ago (2014-10-30 15:52:38 UTC) #3

Benedikt Meurer

6 years, 1 month ago (2014-10-31 05:28:17 UTC) #4

Message was sent while issue was closed.

Thanks for fixing. After thinking about why Dan's constant folding for
comparisons would break Dead Trigger 2, I was already worried that this
optimization could be wrong as well.

Expand Messages | Collapse Messages