content/child/webcrypto/status.h - Issue 689883002: Throw a SyntaxError when importing keys with invalid usages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/webcrypto/status.h

Issue 689883002: Throw a SyntaxError when importing keys with invalid usages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/child/webcrypto/status.h

diff --git a/content/child/webcrypto/status.h b/content/child/webcrypto/status.h

index 4c1aae6e1857a1d047839c2e1516d52c9d24cfbd..4bb12041feff4a03bfe24143609d1d7e8121e40d 100644

--- a/content/child/webcrypto/status.h

+++ b/content/child/webcrypto/status.h

@@ -211,7 +211,8 @@ class CONTENT_EXPORT Status {

// Attempted to create a key (either by importKey(), generateKey(), or

eroman 2014/10/30 19:03:30 This comment is no longer applicable, please updat

// unwrapKey()) however the key usages were not applicable for the key type

// and algorithm.

- static Status ErrorCreateKeyBadUsages();

+ static Status SyntaxError();

+ static Status SyntaxError(const std::string& parameter);

private:

enum Type { TYPE_ERROR, TYPE_SUCCESS };

« no previous file with comments | « content/child/webcrypto/openssl/rsa_key_openssl.cc ('k') | content/child/webcrypto/status.cc » ('j') | content/child/webcrypto/status.cc » ('J')