Throw a SyntaxError when importing keys with invalid usages

Throw a SyntaxError when importing keys with invalid usages

BUG=425651
R=eroman@chromium.org

Committed: https://crrev.com/60b6b9813812919baa918f3c498b50145fd32fd3
Cr-Commit-Position: refs/heads/master@{#302696}

[eroman, 2014-10-30 19:03:30]

(1) This change will not compile under the NSS build --
ErrorCreateKeyBadUsages() is referenced elsewhere

(2) The new error text is less descriptive than before, I don't think it is a
good change.

To address the bug it should be sufficient to just do a 1 line change to
ErrorCreateKeyBadUsages() and change WebCryptoErrorTypeData -->
WebCryptoErrorTypeSyntax.


If you would like to propose different error text that can be done separately
and we can discuss.

https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
File content/child/webcrypto/status.cc (right):

https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
content/child/webcrypto/status.cc:242: return
Status(blink::WebCryptoErrorTypeSyntax,
The formatting is not correct. Run "git cl format" to fix it.

https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
content/child/webcrypto/status.cc:248: "Parameter '" +parameter + "' was missing
or out-of-range.");
The formatting is incorrect. Run "git cl format" to fix.

https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
File content/child/webcrypto/status.h (right):

https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
content/child/webcrypto/status.h:211: // Attempted to create a key (either by
importKey(), generateKey(), or
This comment is no longer applicable, please update.

[xun.sun, 2014-10-31 05:41:19]

On 2014/10/30 19:03:30, eroman wrote:
> (1) This change will not compile under the NSS build --
> ErrorCreateKeyBadUsages() is referenced elsewhere
> 
> (2) The new error text is less descriptive than before, I don't think it is a
> good change.
> 
> To address the bug it should be sufficient to just do a 1 line change to
> ErrorCreateKeyBadUsages() and change WebCryptoErrorTypeData -->
> WebCryptoErrorTypeSyntax.
> 
> 
> If you would like to propose different error text that can be done separately
> and we can discuss.
> 
>
https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
> File content/child/webcrypto/status.cc (right):
> 
>
https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
> content/child/webcrypto/status.cc:242: return
> Status(blink::WebCryptoErrorTypeSyntax,
> The formatting is not correct. Run "git cl format" to fix it.
> 
>
https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
> content/child/webcrypto/status.cc:248: "Parameter '" +parameter + "' was
missing
> or out-of-range.");
> The formatting is incorrect. Run "git cl format" to fix.
> 
>
https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
> File content/child/webcrypto/status.h (right):
> 
>
https://codereview.chromium.org/689883002/diff/1/content/child/webcrypto/stat...
> content/child/webcrypto/status.h:211: // Attempted to create a key (either by
> importKey(), generateKey(), or
> This comment is no longer applicable, please update.

I'm following the one line change you suggested. My intended use of the new
SyntaxError class would inherently lead to less descriptive error messages.
PTAL.

[eroman, 2014-11-04 20:37:22]

The CQ bit was checked by eroman@chromium.org

[eroman, 2014-11-04 20:37:23]

lgtm

[commit-bot: I haz the power, 2014-11-04 20:38:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/689883002/20001

[commit-bot: I haz the power, 2014-11-04 22:57:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-04 22:59:01]

Patchset 2 (id:??) landed as
https://crrev.com/60b6b9813812919baa918f3c498b50145fd32fd3
Cr-Commit-Position: refs/heads/master@{#302696}