Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 689873004: Revert of Adds ozone support for ime keyboard. (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
Shu Chen, FengYuan
CC:
chromium-reviews, nona+watch_chromium.org, stevenjb+watch_chromium.org, yusukes+watch_chromium.org, oshima+watch_chromium.org, yukishiino+watch_chromium.org, kpschoedel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Adds ozone support for ime keyboard. (patchset #7 id:120001 of https://codereview.chromium.org/683773002/) Reason for revert: Change doesn't compile on Linux ChromiumOS Ozone Builder http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Ozone%20Builder&number=6030 Original issue's description: > Adds ozone support for ime keyboard. > > BUG=342336 > > Committed: https://crrev.com/8be55caf3d38bba7645de143f7e6b8b655fdd36c > Cr-Commit-Position: refs/heads/master@{#302057} TBR=shuchen@chromium.org,fengyuan@chromium.org NOTREECHECKS=true NOTRY=true BUG=342336 Committed: https://crrev.com/b423f89fac24b9646ae20f1620d776a969673404 Cr-Commit-Position: refs/heads/master@{#302062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -237 lines) Patch
M chromeos/chromeos.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/ime/fake_ime_keyboard.h View 2 chunks +12 lines, -3 lines 0 comments Download
M chromeos/ime/fake_ime_keyboard.cc View 3 chunks +32 lines, -10 lines 0 comments Download
M chromeos/ime/ime_keyboard.h View 4 chunks +8 lines, -15 lines 0 comments Download
D chromeos/ime/ime_keyboard.cc View 1 chunk +0 lines, -105 lines 0 comments Download
D chromeos/ime/ime_keyboard_ozone.h View 1 chunk +0 lines, -40 lines 0 comments Download
M chromeos/ime/ime_keyboard_ozone.cc View 1 chunk +3 lines, -51 lines 0 comments Download
M chromeos/ime/ime_keyboard_x11.h View 3 chunks +14 lines, -0 lines 0 comments Download
M chromeos/ime/ime_keyboard_x11.cc View 9 chunks +83 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
Created Revert of Adds ozone support for ime keyboard.
6 years, 1 month ago (2014-10-30 10:12:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689873004/1
6 years, 1 month ago (2014-10-30 10:12:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 10:13:28 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 10:14:07 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b423f89fac24b9646ae20f1620d776a969673404
Cr-Commit-Position: refs/heads/master@{#302062}

Powered by Google App Engine
This is Rietveld 408576698