Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc

Issue 689863002: Made the revoke buttons in the App Info dialog tab-navigable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@auto_focus_button_dialog
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
diff --git a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
index fdfb8109759643bb82de56851251e5dc8b34a108..37f8118eb829ca0939a1067085dc390e2454beff 100644
--- a/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
+++ b/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
@@ -54,6 +54,12 @@ class RevokeButton : public views::ImageButton, public views::ButtonListener {
rb.GetImageNamed(IDR_DISABLE_P).ToImageSkia());
SetBorder(scoped_ptr<views::Border>());
SetSize(GetPreferredSize());
+
+ // Make the button focusable & give it alt-text so permissions can be
+ // revoked using only the keyboard.
+ SetFocusable(true);
+ SetTooltipText(l10n_util::GetStringUTF16(
+ IDS_APPLICATION_INFO_REVOKE_PERMISSION_ALT_TEXT));
}
virtual ~RevokeButton() {}
« chrome/app/generated_resources.grd ('K') | « chrome/app/generated_resources.grd ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698