Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 689863002: Made the revoke buttons in the App Info dialog tab-navigable (Closed)

Created:
6 years, 1 month ago by sashab
Modified:
6 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@auto_focus_button_dialog
Project:
chromium
Visibility:
Public.

Description

Made the revoke buttons in the App Info dialog tab-navigable Added alt-text and focusability to the revoke buttons in the App Info dialog so they can be navigated to with the keyboard. This allows permissions to be revoked for apps for users who are navigating with a screen reader or only using the keyboard. BUG=425311 Committed: https://crrev.com/15c2942b68a2e52c881c8e45aa8e0fbe52157d3f Cr-Commit-Position: refs/heads/master@{#302405}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed generic 'Revoke' message to refer to the specific permission #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc View 1 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sashab
6 years, 1 month ago (2014-10-30 04:45:14 UTC) #2
benwells
https://codereview.chromium.org/689863002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/689863002/diff/1/chrome/app/generated_resources.grd#newcode2245 chrome/app/generated_resources.grd:2245: + Revoke this permission Will this help someone using ...
6 years, 1 month ago (2014-10-30 21:49:07 UTC) #3
sashab
https://codereview.chromium.org/689863002/diff/1/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/689863002/diff/1/chrome/app/generated_resources.grd#newcode2245 chrome/app/generated_resources.grd:2245: + Revoke this permission On 2014/10/30 21:49:06, benwells wrote: ...
6 years, 1 month ago (2014-10-31 02:10:25 UTC) #4
benwells
lgtm
6 years, 1 month ago (2014-11-02 21:08:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689863002/20001
6 years, 1 month ago (2014-11-02 21:54:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-02 22:35:24 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-02 22:36:04 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15c2942b68a2e52c881c8e45aa8e0fbe52157d3f
Cr-Commit-Position: refs/heads/master@{#302405}

Powered by Google App Engine
This is Rietveld 408576698