Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 689783002: Refactor RtcDataChannelHandler. (Closed)

Created:
6 years, 1 month ago by tommi (sloooow) - chröme
Modified:
6 years, 1 month ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor RtcDataChannelHandler. This change splits the WebRtc observer functionality of RtcDataChannelHandler from the WebKit related functionality. The former belongs with libjingle's signaling thread and the latter with the main thread. As is, these threads are one and the same, but this will change later this week. This is a re-land of: https://codereview.chromium.org/643693007 BUG=369796 TBR=perkj Committed: https://crrev.com/b545339a3c886a00b899d74398f4db9e84ed6385 Cr-Commit-Position: refs/heads/master@{#302044}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -69 lines) Patch
M content/renderer/media/rtc_data_channel_handler.h View 3 chunks +52 lines, -9 lines 0 comments Download
M content/renderer/media/rtc_data_channel_handler.cc View 4 chunks +135 lines, -31 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 2 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
tommi (sloooow) - chröme
Rebase
6 years, 1 month ago (2014-10-29 21:43:45 UTC) #1
tommi (sloooow) - chröme
6 years, 1 month ago (2014-10-29 22:59:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689783002/20001
6 years, 1 month ago (2014-10-29 23:01:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/23565)
6 years, 1 month ago (2014-10-30 00:07:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689783002/20001
6 years, 1 month ago (2014-10-30 05:55:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 06:52:30 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 06:53:01 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b545339a3c886a00b899d74398f4db9e84ed6385
Cr-Commit-Position: refs/heads/master@{#302044}

Powered by Google App Engine
This is Rietveld 408576698