Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: sky/examples/radio.sky

Issue 689763003: Docs: call superclass constructors in radio.sky example (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/examples/radio.sky
diff --git a/sky/examples/radio.sky b/sky/examples/radio.sky
index a253af312169832af9f176f9938ca75329c917e2..ec666d9ec94f99399c781bfe644e2a52eb9a7697 100644
--- a/sky/examples/radio.sky
+++ b/sky/examples/radio.sky
@@ -13,6 +13,7 @@ SKY MODULE - radio button and radio button group
module.exports = {};
module.exports.RadioElement = sky.registerElement('radio', class extends Element {
constructor () {
+ super();
this.addEventListener('click', (event) => this.checked = true);
this.addShadowRoot(new sky.ShadowRoot(module.document.findId('radio-shadow').content.cloneNode(true)));
}
@@ -48,6 +49,7 @@ SKY MODULE - radio button and radio button group
<script>
module.exports.RadioGroupElement = sky.registerElement('radiogroup', class extends Element {
constructor () {
+ super();
this.addShadowRoot(new sky.ShadowRoot(module.document.findId('radiogroup-shadow').content.cloneNode(true)));
}
get value () {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698