Remove building llvm2ice.build_atts from Subzero build.

Remove building llvm2ice.build_atts from Subzero build.

BUG=None
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6af6336dd4e2004850f89a0e23a62f3c2f4f4285

[Karl, 2014-10-29 19:42:24]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Karl, 2014-10-29 21:18:18]

https://codereview.chromium.org/689753002/diff/40001/pydir/if.py
File pydir/if.py (right):

https://codereview.chromium.org/689753002/diff/40001/pydir/if.py#newcode41
pydir/if.py:41: if args.cond == 'true' and set(args.need) <= set(args.have):
Fixed check on args.cond.

[Jim Stichnoth, 2014-10-29 21:29:37]

otherwise lgtm

https://codereview.chromium.org/689753002/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/689753002/diff/20001/Makefile.standalone#newc...
Makefile.standalone:123: @$(OBJDIR)/llvm2ice --build-atts
This is done just to let the user know what the build-atts are?

How about ./llvm2ice instead, to "test" the new symlink?

https://codereview.chromium.org/689753002/diff/20001/pydir/if.py
File pydir/if.py (right):

https://codereview.chromium.org/689753002/diff/20001/pydir/if.py#newcode20
pydir/if.py:20: argparser.add_argument('--cond', choices={'true', 'false'} ,
required=False,
A little bikeshedding.  What about:

argparser.add_argument('--cond-true',  dest='cond', action='store_true')
argparser.add_argument('--cond-false', dest='cond', action='store_false')

(And I was going to ask how the test below on args.cond could possibly work, but
I see you fixed it... :)

https://codereview.chromium.org/689753002/diff/40001/tests_lit/lit.cfg
File tests_lit/lit.cfg (right):

https://codereview.chromium.org/689753002/diff/40001/tests_lit/lit.cfg#newcode79
tests_lit/lit.cfg:79: if Value:
return '--cond=true' if Value else '--cond=false'

https://codereview.chromium.org/689753002/diff/40001/tests_lit/lit.cfg#newcode86
tests_lit/lit.cfg:86: if_atts_cmd = (if_atts + ['--have=' + att for att in
llvm2iceatts] +
remove parens

[Karl, 2014-10-29 21:55:06]

Committed patchset #4 (id:60001) manually as
6af6336dd4e2004850f89a0e23a62f3c2f4f4285 (presubmit successful).

[Karl, 2014-10-29 21:55:28]

https://codereview.chromium.org/689753002/diff/20001/Makefile.standalone
File Makefile.standalone (right):

https://codereview.chromium.org/689753002/diff/20001/Makefile.standalone#newc...
Makefile.standalone:123: @$(OBJDIR)/llvm2ice --build-atts
On 2014/10/29 21:29:36, stichnot wrote:
> This is done just to let the user know what the build-atts are?
> 
> How about ./llvm2ice instead, to "test" the new symlink?

Actually, it also verifies that the define flags are properly defined (this is
checked by llvm2ice), and generates an error if there is a problem.

Changed to use the new symlink.

https://codereview.chromium.org/689753002/diff/20001/pydir/if.py
File pydir/if.py (right):

https://codereview.chromium.org/689753002/diff/20001/pydir/if.py#newcode20
pydir/if.py:20: argparser.add_argument('--cond', choices={'true', 'false'} ,
required=False,
On 2014/10/29 21:29:37, stichnot wrote:
> A little bikeshedding.  What about:
> 
> argparser.add_argument('--cond-true',  dest='cond', action='store_true')
> argparser.add_argument('--cond-false', dest='cond', action='store_false')
> 
> (And I was going to ask how the test below on args.cond could possibly work,
but
> I see you fixed it... :)

We can't use the same desc field for two different arguments. argparse does not
allow this. Leaving as is.

https://codereview.chromium.org/689753002/diff/40001/tests_lit/lit.cfg
File tests_lit/lit.cfg (right):

https://codereview.chromium.org/689753002/diff/40001/tests_lit/lit.cfg#newcode79
tests_lit/lit.cfg:79: if Value:
On 2014/10/29 21:29:37, stichnot wrote:
> return '--cond=true' if Value else '--cond=false'

Done.

https://codereview.chromium.org/689753002/diff/40001/tests_lit/lit.cfg#newcode86
tests_lit/lit.cfg:86: if_atts_cmd = (if_atts + ['--have=' + att for att in
llvm2iceatts] +
On 2014/10/29 21:29:37, stichnot wrote:
> remove parens

The parens were added because the instruction crosses multiple lines, but not at
a point where a parenthesis is. Without it, you get a Python syntax error.

To remove them, I have broken the list comprehension across two lines.