sky/engine/core/css/resolver/FontBuilder.cpp - Issue 689743002: First past at removing writing mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/resolver/FontBuilder.cpp

Issue 689743002: First past at removing writing mode. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/css/resolver/FontBuilder.cpp

diff --git a/sky/engine/core/css/resolver/FontBuilder.cpp b/sky/engine/core/css/resolver/FontBuilder.cpp

index 1aa74db5cea36d5f290d5fe941839c8d518cdc1e..6dab4e6b41c7720033c3e7d0dbb59bc6c136ab19 100644

--- a/sky/engine/core/css/resolver/FontBuilder.cpp

+++ b/sky/engine/core/css/resolver/FontBuilder.cpp

@@ -457,12 +457,6 @@ static void getFontAndGlyphOrientation(const RenderStyle* style, FontOrientation

glyphOrientation = NonCJKGlyphOrientationUpright;

return;

case TextOrientationSideways:

- if (style->writingMode() == LeftToRightWritingMode) {

- // FIXME: This should map to sideways-left, which is not supported yet.

- fontOrientation = Vertical;

- glyphOrientation = NonCJKGlyphOrientationVerticalRight;

- return;

- }

fontOrientation = Horizontal;

glyphOrientation = NonCJKGlyphOrientationVerticalRight;

return;