sky/engine/core/rendering/RenderBoxModelObject.cpp - Issue 689733003: Remove most of FloatingObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBoxModelObject.cpp

Issue 689733003: Remove most of FloatingObject. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBoxModelObject.cpp

diff --git a/sky/engine/core/rendering/RenderBoxModelObject.cpp b/sky/engine/core/rendering/RenderBoxModelObject.cpp

index 6ffb0e9077f362c1a5befc8194712ab4508f0b64..007cfb9d33cacd5eee2800e460570a614100f90b 100644

--- a/sky/engine/core/rendering/RenderBoxModelObject.cpp

+++ b/sky/engine/core/rendering/RenderBoxModelObject.cpp

@@ -2629,8 +2629,6 @@ void RenderBoxModelObject::moveChildrenTo(RenderBoxModelObject* toBoxModelObject

if (fullRemoveInsert && isRenderBlock()) {

RenderBlock* block = toRenderBlock(this);

block->removePositionedObjects(0);

- if (block->isRenderBlockFlow())

- toRenderBlockFlow(block)->removeFloatingObjects();

}

ASSERT(!beforeChild || toBoxModelObject == beforeChild->parent());