Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: src/lazy/SkCachingPixelRef.h

Issue 68973005: Expand pixelref to return SkImageInfo and rowbytes (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: new convention: require SkImageInfo in constructor Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/lazy/SkCachingPixelRef.h
diff --git a/src/lazy/SkCachingPixelRef.h b/src/lazy/SkCachingPixelRef.h
index db968dfcdde27ce29cdab589be07413075d084be..b49d84c0be2e413cce9d6b9fc02e87944c0a4f74 100644
--- a/src/lazy/SkCachingPixelRef.h
+++ b/src/lazy/SkCachingPixelRef.h
@@ -26,11 +26,11 @@ class SkColorTable;
*/
class SkCachingPixelRef : public SkPixelRef {
public:
- SkCachingPixelRef();
+ SkCachingPixelRef(const SkImageInfo&);
virtual ~SkCachingPixelRef();
protected:
- virtual void* onLockPixels(SkColorTable** colorTable) SK_OVERRIDE;
+ virtual bool onNewLockPixels(LockRec*) SK_OVERRIDE;
virtual void onUnlockPixels() SK_OVERRIDE;
virtual bool onLockPixelsAreWritable() const SK_OVERRIDE { return false; }
virtual bool onImplementsDecodeInto() SK_OVERRIDE { return true; }
@@ -43,16 +43,6 @@ protected:
bool configure(SkBitmap* bitmap);
/**
- * Cache info from onDecodeInfo(). Returns false on failure.
- */
- bool getInfo(SkImageInfo* info);
-
- /**
- * Return some information about the pixels, allowing this class
- * to allocate pixels. @return false if anything goes wrong.
- */
- virtual bool onDecodeInfo(SkImageInfo* info) = 0;
- /**
* Decode into the given pixels, a block of memory of size
* (info.fHeight - 1) * rowBytes + (info.fWidth * bytesPerPixel)
*
@@ -65,14 +55,11 @@ protected:
*
* @return false if anything goes wrong.
*/
- virtual bool onDecodePixels(const SkImageInfo& info,
- void* pixels,
- size_t rowBytes) = 0;
+ virtual bool onDecodePixels(void* pixels, size_t rowBytes) = 0;
private:
- bool fErrorInDecoding;
- void* fScaledCacheId;
- SkImageInfo fInfo;
+ void* fScaledCacheId;
+ bool fErrorInDecoding;
typedef SkPixelRef INHERITED;
};

Powered by Google App Engine
This is Rietveld 408576698