src/core/SkMaskFilter.cpp - Issue 68973005: Expand pixelref to return SkImageInfo and rowbytes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkMaskFilter.cpp

Issue 68973005: Expand pixelref to return SkImageInfo and rowbytes (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: new convention: require SkImageInfo in constructor Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkMaskFilter.cpp

diff --git a/src/core/SkMaskFilter.cpp b/src/core/SkMaskFilter.cpp

index cd2571637749ac1f318ada65167ba7ab1aa0187e..e02b83b84f0f207e86b19df1a773255ab4b4d78b 100644

--- a/src/core/SkMaskFilter.cpp

+++ b/src/core/SkMaskFilter.cpp

@@ -351,10 +351,14 @@ bool SkMaskFilter::filterMaskGPU(GrContext* context,

if (!result) {

return false;

}

+ SkAutoUnref aur(dst);

+ SkImageInfo info;

resultBM->setConfig(srcBM.config(), dst->width(), dst->height());

- resultBM->setPixelRef(SkNEW_ARGS(SkGrPixelRef, (dst)))->unref();

- dst->unref();

+ if (resultBM->asImageInfo(&info)) {

+ return false;

+ }

+ resultBM->setPixelRef(SkNEW_ARGS(SkGrPixelRef, (info, dst)))->unref();

return true;

}