Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: src/lazy/SkDiscardablePixelRef.cpp

Issue 68973005: Expand pixelref to return SkImageInfo and rowbytes (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: new convention: require SkImageInfo in constructor Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkDiscardablePixelRef.h" 8 #include "SkDiscardablePixelRef.h"
9 #include "SkDiscardableMemory.h" 9 #include "SkDiscardableMemory.h"
10 10
11 SkDiscardablePixelRef::SkDiscardablePixelRef(SkImageGenerator* generator, 11 SkDiscardablePixelRef::SkDiscardablePixelRef(SkImageGenerator* generator,
12 const SkImageInfo& info, 12 const SkImageInfo& info,
13 size_t size, 13 size_t size,
14 size_t rowBytes) 14 size_t rowBytes)
15 : fGenerator(generator) 15 : INHERITED(info)
16 , fInfo(info) 16 , fGenerator(generator)
17 , fSize(size) 17 , fSize(size)
18 , fRowBytes(rowBytes) 18 , fRowBytes(rowBytes)
19 , fDiscardableMemory(NULL) { 19 , fDiscardableMemory(NULL) {
20 SkASSERT(fGenerator != NULL); 20 SkASSERT(fGenerator != NULL);
21 SkASSERT(fSize > 0); 21 SkASSERT(fSize > 0);
22 SkASSERT(fRowBytes > 0); 22 SkASSERT(fRowBytes > 0);
23 // The SkImageGenerator contract requires fGenerator to always 23 // The SkImageGenerator contract requires fGenerator to always
24 // decode the same image on each call to getPixels(). 24 // decode the same image on each call to getPixels().
25 this->setImmutable(); 25 this->setImmutable();
26 } 26 }
27 27
28 SkDiscardablePixelRef::~SkDiscardablePixelRef() { 28 SkDiscardablePixelRef::~SkDiscardablePixelRef() {
29 SkDELETE(fGenerator); 29 SkDELETE(fGenerator);
30 } 30 }
31 31
32 void* SkDiscardablePixelRef::onLockPixels(SkColorTable**) { 32 bool SkDiscardablePixelRef::onNewLockPixels(LockRec* rec) {
33 if (fDiscardableMemory != NULL) { 33 if (fDiscardableMemory != NULL) {
34 if (fDiscardableMemory->lock()) { 34 if (fDiscardableMemory->lock()) {
35 return fDiscardableMemory->data(); 35 rec->fPixels = fDiscardableMemory->data();
36 rec->fColorTable = NULL;
37 rec->fRowBytes = fRowBytes;
38 return true;
36 } 39 }
37 fDiscardableMemory = NULL; 40 fDiscardableMemory = NULL;
38 } 41 }
39 fDiscardableMemory = SkDiscardableMemory::Create(fSize); 42 fDiscardableMemory = SkDiscardableMemory::Create(fSize);
40 if (NULL == fDiscardableMemory) { 43 if (NULL == fDiscardableMemory) {
41 return NULL; // Memory allocation failed. 44 return false; // Memory allocation failed.
42 } 45 }
43 void* pixels = fDiscardableMemory->data(); 46 void* pixels = fDiscardableMemory->data();
44 if (!fGenerator->getPixels(fInfo, pixels, fRowBytes)) { 47 if (!fGenerator->getPixels(this->info(), pixels, fRowBytes)) {
45 return NULL; // TODO(halcanary) Find out correct thing to do. 48 return false; // TODO(halcanary) Find out correct thing to do.
46 } 49 }
47 return pixels; 50
51 rec->fPixels = pixels;
52 rec->fColorTable = NULL;
53 rec->fRowBytes = fRowBytes;
54 return true;
48 } 55 }
49 void SkDiscardablePixelRef::onUnlockPixels() { 56 void SkDiscardablePixelRef::onUnlockPixels() {
50 if (fDiscardableMemory != NULL) { 57 if (fDiscardableMemory != NULL) {
51 fDiscardableMemory->unlock(); 58 fDiscardableMemory->unlock();
52 } 59 }
53 } 60 }
54 61
55 bool SkDiscardablePixelRef::Install(SkImageGenerator* generator, 62 bool SkDiscardablePixelRef::Install(SkImageGenerator* generator,
56 SkBitmap* dst) { 63 SkBitmap* dst) {
57 SkImageInfo info; 64 SkImageInfo info;
58 SkASSERT(generator != NULL); 65 SkASSERT(generator != NULL);
59 if ((NULL == generator) 66 if ((NULL == generator)
60 || (!generator->getInfo(&info)) 67 || (!generator->getInfo(&info))
61 || (!dst->setConfig(info, 0))) { 68 || (!dst->setConfig(info, 0))) {
62 SkDELETE(generator); 69 SkDELETE(generator);
63 return false; 70 return false;
64 } 71 }
65 SkAutoTUnref<SkDiscardablePixelRef> ref(SkNEW_ARGS(SkDiscardablePixelRef, 72 SkAutoTUnref<SkDiscardablePixelRef> ref(SkNEW_ARGS(SkDiscardablePixelRef,
66 (generator, info, 73 (generator, info,
67 dst->getSize(), 74 dst->getSize(),
68 dst->rowBytes()))); 75 dst->rowBytes())));
69 dst->setPixelRef(ref); 76 dst->setPixelRef(ref);
70 return true; 77 return true;
71 } 78 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698