Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: src/images/SkImageRef.cpp

Issue 68973005: Expand pixelref to return SkImageInfo and rowbytes (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: add SK_SUPPORT_LEGACY_ONLOCKPIXELS so we can land in stages for Chrome Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 1
2 /* 2 /*
3 * Copyright 2011 Google Inc. 3 * Copyright 2011 Google Inc.
4 * 4 *
5 * Use of this source code is governed by a BSD-style license that can be 5 * Use of this source code is governed by a BSD-style license that can be
6 * found in the LICENSE file. 6 * found in the LICENSE file.
7 */ 7 */
8 #include "SkImageRef.h" 8 #include "SkImageRef.h"
9 #include "SkBitmap.h" 9 #include "SkBitmap.h"
10 #include "SkFlattenableBuffers.h" 10 #include "SkFlattenableBuffers.h"
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 } else { 136 } else {
137 SkDebugf("--- ImageRef: <%s> failed in codec for %d mode\n", 137 SkDebugf("--- ImageRef: <%s> failed in codec for %d mode\n",
138 this->getURI(), mode); 138 this->getURI(), mode);
139 } 139 }
140 #endif 140 #endif
141 fErrorInDecoding = true; 141 fErrorInDecoding = true;
142 fBitmap.reset(); 142 fBitmap.reset();
143 return false; 143 return false;
144 } 144 }
145 145
146 void* SkImageRef::onLockPixels(SkColorTable** ct) { 146 bool SkImageRef::onGetInfo(SkImageInfo* info) {
147 return fBitmap.asImageInfo(info);
148 }
149
150 bool SkImageRef::onNewLockPixels(LockRec* rec) {
147 if (NULL == fBitmap.getPixels()) { 151 if (NULL == fBitmap.getPixels()) {
148 (void)this->prepareBitmap(SkImageDecoder::kDecodePixels_Mode); 152 (void)this->prepareBitmap(SkImageDecoder::kDecodePixels_Mode);
149 } 153 }
150 154
151 if (ct) { 155 if (NULL == fBitmap.getPixels()) {
152 *ct = fBitmap.getColorTable(); 156 return false;
153 } 157 }
154 return fBitmap.getPixels(); 158 rec->fPixels = fBitmap.getPixels();
159 rec->fColorTable = NULL;
160 rec->fRowBytes = fBitmap.rowBytes();
161 return true;
155 } 162 }
156 163
157 size_t SkImageRef::ramUsed() const { 164 size_t SkImageRef::ramUsed() const {
158 size_t size = 0; 165 size_t size = 0;
159 166
160 if (fBitmap.getPixels()) { 167 if (fBitmap.getPixels()) {
161 size = fBitmap.getSize(); 168 size = fBitmap.getSize();
162 if (fBitmap.getColorTable()) { 169 if (fBitmap.getColorTable()) {
163 size += fBitmap.getColorTable()->count() * sizeof(SkPMColor); 170 size += fBitmap.getColorTable()->count() * sizeof(SkPMColor);
164 } 171 }
(...skipping 28 matching lines...) Expand all
193 // now. 200 // now.
194 if (!fStream->rewind()) { 201 if (!fStream->rewind()) {
195 SkDEBUGF(("Failed to rewind SkImageRef stream!")); 202 SkDEBUGF(("Failed to rewind SkImageRef stream!"));
196 buffer.write32(0); 203 buffer.write32(0);
197 } else { 204 } else {
198 // FIXME: Handle getLength properly here. Perhaps this class should 205 // FIXME: Handle getLength properly here. Perhaps this class should
199 // take an SkStreamAsset. 206 // take an SkStreamAsset.
200 buffer.writeStream(fStream, fStream->getLength()); 207 buffer.writeStream(fStream, fStream->getLength());
201 } 208 }
202 } 209 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698