Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 689723005: Update permissions for Smart Lock setup app. (Closed)

Created:
6 years, 1 month ago by Tim Song
Modified:
6 years, 1 month ago
Reviewers:
xiyuan
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update permissions for Smart Lock setup app. chrome.browser.openTab allows us to bypass security checks to open chrome://settings from the app. chrome.tabs is only allowed for extensions, not apps. BUG=398656 NOTRY=true Committed: https://crrev.com/f264dce3bcaf59187834def5bc2ceee055429953 Cr-Commit-Position: refs/heads/master@{#301951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/easy_unlock/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Tim Song
6 years, 1 month ago (2014-10-29 21:23:59 UTC) #2
xiyuan
lgtm
6 years, 1 month ago (2014-10-29 21:25:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689723005/1
6 years, 1 month ago (2014-10-29 22:10:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 22:13:19 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 22:14:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f264dce3bcaf59187834def5bc2ceee055429953
Cr-Commit-Position: refs/heads/master@{#301951}

Powered by Google App Engine
This is Rietveld 408576698