Allow POSIX callers to specify a new file's mode.

base/files/file_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
@@ skipping 2125 matching lines @@
 
   ASSERT_TRUE(TouchFile(foobar, access_time, modification_time));
   File::Info file_info;
   ASSERT_TRUE(GetFileInfo(foobar, &file_info));
   EXPECT_EQ(access_time.ToInternalValue(),
             file_info.last_accessed.ToInternalValue());
   EXPECT_EQ(modification_time.ToInternalValue(),
             file_info.last_modified.ToInternalValue());
 }
 
+#if defined(OS_POSIX) && !defined(OS_ANDROID)
+TEST_F(FileUtilTest, WriteFileWithMode) {
+  FilePath data_dir =
+      temp_dir_.path().Append(FILE_PATH_LITERAL("FilePathTest"));
+
+  // Create a fresh, empty copy of this directory.
+  if (PathExists(data_dir)) {

[asanka, 2014/11/03 14:44:57]

This test, and the creation of a separate test directory should not be necessary
since it implies that temp_dir_ is not unique. The test fixture is supposed to
guarantee that it is unique per test. I.e. each individual test is given a
freshly constructed fixture including its own temp directory.

+    ASSERT_TRUE(DeleteFile(data_dir, true));
+  }
+  ASSERT_TRUE(CreateDirectory(data_dir));
+
+  FilePath foobar(data_dir.Append(FILE_PATH_LITERAL("foobar.txt")));
+  std::string data("hello");
+  mode_t mode = 0644;
+  ASSERT_TRUE(WriteFileWithMode(foobar, data.c_str(), data.length(), mode));
+
+  struct stat status;
+  ASSERT_EQ(0, stat(foobar.value().c_str(), &status));

[asanka, 2014/11/03 14:44:57]

Is there's a more aggressive umask on the MSan bots? If the umask is something
like 066, then we could end up with the results we are seeing. I can't tell for
sure without knowing what the configuration there is.

I agree with you that unless there's a memory access error or something, a test
that passes on the Linux bot should pass on the Linux MSan bot. But I also think
it might be best for the test to account for non-standard umasks, either by
explicitly setting a umask, or taking the umask into account.

This has to be done carefully, since if the test is not running in its own
process, then it is running in series with other tests. So we have to restore
the umask to its former glory before returning.

I prefer setting an explicit umask since otherwise the test wouldn't be testing
anything if the umask in effect is overly aggressive.

+  ASSERT_EQ(mode, status.st_mode & 0777);
+}
+#endif
+
 TEST_F(FileUtilTest, IsDirectoryEmpty) {
   FilePath empty_dir = temp_dir_.path().Append(FILE_PATH_LITERAL("EmptyDir"));
 
   ASSERT_FALSE(PathExists(empty_dir));
 
   ASSERT_TRUE(CreateDirectory(empty_dir));
 
   EXPECT_TRUE(IsDirectoryEmpty(empty_dir));
 
   FilePath foo(empty_dir.Append(FILE_PATH_LITERAL("foo.txt")));
@@ skipping 451 matching lines @@
   // Trying to close it should crash. This is important for security.
   EXPECT_DEATH(CloseWithScopedFD(fds[1]), "");
 #endif
 }
 
 #endif  // defined(OS_POSIX)
 
 }  // namespace
 
 }  // namespace base