Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6728)

Unified Diff: chrome/browser/chromeos/login/lock/webui_screen_locker.cc

Issue 689683004: Make login code not depend on Ash when use_athena=1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@athena_do_not_use_ash44_ui
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/lock/webui_screen_locker.cc
diff --git a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
index 7d0f5cde14c969b02815940a687f6fdcd5617623..ec4419f73e9f33e3437b28058b39c5f080dda86e 100644
--- a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
+++ b/chrome/browser/chromeos/login/lock/webui_screen_locker.cc
@@ -4,9 +4,6 @@
#include "chrome/browser/chromeos/login/lock/webui_screen_locker.h"
-#include "ash/shell.h"
-#include "ash/wm/lock_state_controller.h"
-#include "ash/wm/lock_state_observer.h"
#include "base/command_line.h"
#include "base/metrics/histogram.h"
#include "base/strings/utf_string_conversions.h"
@@ -35,6 +32,12 @@
#include "ui/keyboard/keyboard_util.h"
#include "ui/views/controls/webview/webview.h"
+#if !defined(USE_ATHENA)
+#include "ash/shell.h"
+#include "ash/wm/lock_state_controller.h"
+#include "ash/wm/lock_state_observer.h"
+#endif
+
namespace {
// URL which corresponds to the login WebUI.
@@ -80,7 +83,10 @@ WebUIScreenLocker::WebUIScreenLocker(ScreenLocker* screen_locker)
}
void WebUIScreenLocker::LockScreen() {
- gfx::Rect bounds(ash::Shell::GetScreen()->GetPrimaryDisplay().bounds());
+ gfx::Rect bounds;
+#if !defined(USE_ATHENA)
+ bounds = ash::Shell::GetScreen()->GetPrimaryDisplay().bounds();
oshima 2014/10/30 18:11:42 ditto
+#endif
lock_time_ = base::TimeTicks::Now();
LockWindow* lock_window = LockWindow::Create();
@@ -303,6 +309,7 @@ void WebUIScreenLocker::OnLockWindowReady() {
////////////////////////////////////////////////////////////////////////////////
// SessionLockStateObserver override.
+#if !defined(USE_ATHENA)
void WebUIScreenLocker::OnLockStateEvent(
ash::LockStateObserver::EventType event) {
if (event == ash::LockStateObserver::EVENT_LOCK_ANIMATION_FINISHED) {
@@ -312,6 +319,7 @@ void WebUIScreenLocker::OnLockStateEvent(
GetWebUI()->CallJavascriptFunction("cr.ui.Oobe.animateOnceFullyDisplayed");
}
}
+#endif
////////////////////////////////////////////////////////////////////////////////
// WidgetObserver override.
@@ -350,6 +358,7 @@ void WebUIScreenLocker::RenderProcessGone(base::TerminationStatus status) {
////////////////////////////////////////////////////////////////////////////////
// ash::KeyboardStateObserver overrides.
+#if !defined(USE_ATHENA)
void WebUIScreenLocker::OnVirtualKeyboardStateChanged(bool activated) {
if (keyboard::KeyboardController::GetInstance()) {
if (activated) {
@@ -363,6 +372,7 @@ void WebUIScreenLocker::OnVirtualKeyboardStateChanged(bool activated) {
}
}
}
+#endif
////////////////////////////////////////////////////////////////////////////////
// keyboard::KeyboardControllerObserver overrides.

Powered by Google App Engine
This is Rietveld 408576698