Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 689673002: Mark as unused the "Closing" UMA entry in ImportantFile.TempFileFailures. (Closed)

Created:
6 years, 1 month ago by Thiemo Nagel
Modified:
6 years ago
CC:
chromium-reviews, tfarina, erikwright+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mark as unused the "Closing" UMA entry in ImportantFile.TempFileFailures. BUG=none Committed: https://crrev.com/f5dccdcb4b32b340c999bf3eac78a95f07e2776e Cr-Commit-Position: refs/heads/master@{#308341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M base/files/important_file_writer.cc View 1 chunk +5 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (8 generated)
Thiemo Nagel
Hi Alexei, Ricardo, could you please take a look? Alexei: histograms.xml Ricardo: important_file_writer.cc Thank you! ...
6 years, 1 month ago (2014-10-29 15:50:33 UTC) #2
Alexei Svitkine (slow)
lgtm, thanks
6 years, 1 month ago (2014-10-29 16:34:11 UTC) #3
rvargas (doing something else)
lgtm
6 years, 1 month ago (2014-11-05 00:25:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689673002/1
6 years, 1 month ago (2014-11-05 05:59:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8745)
6 years, 1 month ago (2014-11-05 07:21:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689673002/1
6 years, 1 month ago (2014-11-05 09:51:24 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8801)
6 years, 1 month ago (2014-11-05 11:07:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689673002/1
6 years, 1 month ago (2014-11-05 12:47:32 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8856)
6 years, 1 month ago (2014-11-05 14:05:27 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689673002/1
6 years ago (2014-12-15 12:37:00 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 13:07:49 UTC) #19
commit-bot: I haz the power
6 years ago (2014-12-15 13:08:33 UTC) #20
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5dccdcb4b32b340c999bf3eac78a95f07e2776e
Cr-Commit-Position: refs/heads/master@{#308341}

Powered by Google App Engine
This is Rietveld 408576698