Issue 689663002: Fix not proper chunk sizes in serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 689663002: Fix not proper chunk sizes in serializer. (Closed)

Created:
6 years, 1 month ago by Slava Chigrin

Modified:
6 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix not proper chunk sizes in serializer. Executable page have guard areas in the begin and end, so maximum payload size is smaller for them. Too large allocations during deserializing caused incorrect registrations in Page::skip_list, so InnerPointerToCodeCache::GcSafeFindCodeForInnerPointer did not work correctly.

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/serialize.cc	View		1 chunk	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Yang

6 years, 1 month ago (2014-10-30 09:36:29 UTC) #3

I made a more comprehensive version that cleans up more things. Thanks for
finding this!

https://codereview.chromium.org/689663002/diff/1/src/serialize.cc
File src/serialize.cc (right):

https://codereview.chromium.org/689663002/diff/1/src/serialize.cc#newcode1923
src/serialize.cc:1923: Page::kMaxRegularHeapObjectSize;
Wouldn't it be easier to use MemoryAllocator::CodePageAreaSize()?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages