content/test/data/accessibility/aria-pressed.html - Issue 689653002: Add DumpAccessibilityTree tests (11 of 20)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/aria-pressed.html

Issue 689653002: Add DumpAccessibilityTree tests (11 of 20) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporating comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/test/data/accessibility/aria-busy-expected-win.txt ('k') | content/test/data/accessibility/aria-pressed-expected-android.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 @WIN-DENY:name*	3 @WIN-DENY:name*

4 @WIN-ALLOW:PRESSED	4 @WIN-ALLOW:PRESSED

5 @WIN-ALLOW:checkable:true	5 @WIN-ALLOW:checkable:true

6 @MAC-ALLOW:AXSubrole=*	6 @MAC-ALLOW:AXSubrole=*

7 @MAC-ALLOW:AXRoleDescription=*	7 @MAC-ALLOW:AXRoleDescription=*

8 -->	8 -->

9 <html>	9 <html>

10 <body>	10 <body>

11 <div tabindex=0 role="button">Regular button</div>	11 <div tabindex=0 role="button">Regular button</div>

12 <div tabindex=1 role="button" aria-pressed="false">Toggle button unpressed</div>	12 <div tabindex=1 role="button" aria-pressed="false">Toggle button unpressed</div>

13 <div tabindex=2 role="button" aria-pressed="true">Toggle button pressed</div>	13 <div tabindex=2 role="button" aria-pressed="true">Toggle button pressed</div>

14 <div tabindex=3 role="button" aria-pressed="mixed">Toggle button mixed</div>	14 <div tabindex=3 role="button" aria-pressed="mixed">Toggle button mixed</div>

	15 <div tabindex=4 role="button" aria-pressed="undefined">Toggle button undefined</ div>
	dmazzoni 2014/11/05 07:10:49 When the spec says that aria-pressed is undefined, When the spec says that aria-pressed is undefined, I don't think they mean aria-pressed="undefined", they mean that the aria-pressed attribute is not present - that case is handled by the first one, a regular button. Right now our logic is that if the aria-pressed attribute is present, it's a toggle button, even if it's not true, false, or mixed - that's probably wrong. shreeramk 2014/11/05 07:25:17 But Why values other than true, false or mixed wil Show quoted text On 2014/11/05 07:10:49, dmazzoni wrote: > When the spec says that aria-pressed is undefined, I don't think they mean > aria-pressed="undefined", they mean that the aria-pressed attribute is not > present - that case is handled by the first one, a regular button. > > Right now our logic is that if the aria-pressed attribute is present, it's a > toggle button, even if it's not true, false, or mixed - that's probably wrong. But Why values other than true, false or mixed will be assigned to aria-pressed? Are you talking about a content of this type?? <div role="button" aria-pressed="ooo">Toggle button unknown</div> Following was the AX output: IA2_ROLE_TOGGLE_BUTTON name='Toggle button unknown' FOCUSABLE xml-roles:button checkable:true
15 </body>	16 </body>

16 </html>	17 </html>

OLD	NEW