LayoutTests/media/controls-css-overload.html - Issue 689613002: Disallow non-flexbox child renderers for RenderMedia

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/controls-css-overload.html

Issue 689613002: Disallow non-flexbox child renderers for RenderMedia (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: nits Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/media/controls-css-overload.html

diff --git a/LayoutTests/media/controls-css-overload.html b/LayoutTests/media/controls-css-overload.html

index 8ac44b512be2084597b4591421ccdc193aa15266..77d7e1859559b3bfe1b3182be67939e18ebe1311 100644

--- a/LayoutTests/media/controls-css-overload.html

+++ b/LayoutTests/media/controls-css-overload.html

@@ -1,25 +1,14 @@

-<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"

- "http://www.w3.org/TR/html4/strict.dtd">

-<html>

-<head>

- <title>Testing that overloading some controls doesn't crash the browser</title>

- <style>

- .nocontrols::-webkit-media-controls-panel{

- display:none;

- }

- .notimeline::-webkit-media-controls-timeline-container{

- display:none;

- }

- </style>

- <script src=video-test.js></script>

-</head>

-<body>

- <video class="nocontrols" width=300 height=200 controls></video>

- <video class="notimeline" width=300 height=200 controls></video>

- <script>

- consoleWrite("I did not crash");

- endTest();

- </script>

-</body>

-</html>

+<!DOCTYPE html>

+<p>Overloading media controls CSS. PASS if it doesn't crash.</p>

+<style>

+ ::-webkit-media-controls {

+ display: inline;

+ }

+ ::-webkit-media-controls-panel {

+ display: none;

+ }

+ ::-webkit-media-controls-timeline-container {

+ display: none;

+ }

+</style>

+<video controls></video>

« no previous file with comments | « no previous file | LayoutTests/media/controls-css-overload-expected.html » ('j') | Source/core/rendering/RenderMedia.cpp » ('J')