LayoutTests/media/webkit-media-controls-webkit-appearance-expected.html - Issue 689613002: Disallow non-flexbox child renderers for RenderMedia

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/webkit-media-controls-webkit-appearance-expected.html

Issue 689613002: Disallow non-flexbox child renderers for RenderMedia (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: test everything Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>Overloading ::-webkit-media-controls -webkit-appearance. PASS if it doesn't c rash.</p>

	3 <style>

	4 div {

	5 position: absolute;
	rune 2014/10/30 12:15:19 In this reference, this absolute positioned is pai In this reference, this absolute positioned is painted behind the controls, but that's only because the controls happen to establish a new stacking context. You should add a z-index: -1 on the div to make sure this doesn't regress if we fix the painting order for the controls. philipj_slow 2014/10/30 12:28:58 Oh, my assumption was that the video would be pain Show quoted text On 2014/10/30 12:15:19, rune wrote: > In this reference, this absolute positioned is painted behind the controls, but > that's only because the controls happen to establish a new stacking context. You > should add a z-index: -1 on the div to make sure this doesn't regress if we fix > the painting order for the controls. Oh, my assumption was that the video would be painted above the div because it's later in the DOM tree. I know nothing about painting order, will add z-index.
	6 width: 300px;

	7 height: 150px;

	8 -webkit-appearance: button;

	9 }

	10 </style>

	11 <div></div>

	12 <video controls></video>

OLD	NEW