LayoutTests/media/webkit-media-controls-display-expected.html - Issue 689613002: Disallow non-flexbox child renderers for RenderMedia

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/webkit-media-controls-display-expected.html

Issue 689613002: Disallow non-flexbox child renderers for RenderMedia (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: test everything Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>Overloading ::-webkit-media-controls display property. PASS if it doesn't cra sh.</p>

	3 <style>

	4 video { width: 200px; height: 30px; }

	5 </style>

	6 <script>

	7 var displayValues = ["-webkit-box", "-webkit-flex", "-webkit-inline-box",

	8 "-webkit-inline-flex", "block", "flex", "grid", "inline", "inline-block",

	9 "inline-flex", "inline-grid", "inline-table", "list-item", "none", "table",

	10 "table-caption", "table-cell", "table-column", "table-column-group",

	11 "table-footer-group", "table-header-group", "table-row", "table-row-group"];

	12

	13 displayValues.forEach(function(value) {

	14 var video = document.createElement("video");
	rune 2014/10/30 12:15:19 I'd probably just write out the video elements in I'd probably just write out the video elements in markup instead of scripting the reference, but this should be fine too. philipj_slow 2014/10/30 12:28:58 I thought this way would make it more explicit whi Show quoted text On 2014/10/30 12:15:19, rune wrote: > I'd probably just write out the video elements in markup instead of scripting > the reference, but this should be fine too. I thought this way would make it more explicit which display values would result in visible controls.
	15 switch (value) {

	16 case "-webkit-flex":

	17 case "-webkit-inline-flex":

	18 case "flex":

	19 case "inline-flex":

	20 video.controls = true;

	21 }

	22 document.body.appendChild(video);

	23 });

	24 </script>

OLD	NEW