LayoutTests/media/controls-css-overload.html - Issue 689613002: Disallow non-flexbox child renderers for RenderMedia

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/controls-css-overload.html

Issue 689613002: Disallow non-flexbox child renderers for RenderMedia (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN"	1 <!DOCTYPE html>

2 "http://www.w3.org/TR/html4/strict.dtd">	2 <title>overloading controls CSS doesn't crash</title>
	mstensho (USE GERRIT) 2014/10/29 10:12:21 Title not necessary. Also, I really think it woul Title not necessary. Also, I really think it would be better to do a dumpAsText() instead of having a reftest, and also have some text that says "PASS if no crash", or something. rune 2014/10/29 10:14:18 Drop <title> and make it a <p> to describe the pas Drop <title> and make it a <p> to describe the pass condition.
3	3 <style>

4 <html>	4 ::-webkit-media-controls {

5 <head>	5 display: inline;

6 <title>Testing that overloading some controls doesn't crash the browser</tit le>	6 }

7 <style>	7 ::-webkit-media-controls-panel {

8 .nocontrols::-webkit-media-controls-panel{	8 display: none;

9 display:none;	9 }

10 }	10 ::-webkit-media-controls-timeline-container {

11 .notimeline::-webkit-media-controls-timeline-container{	11 display: none;

12 display:none;	12 }

13 }	13 </style>

14 </style>	14 <video controls></video>

15 <script src=video-test.js></script>

16 </head>

17 <body>

18 <video class="nocontrols" width=300 height=200 controls></video>

19 <video class="notimeline" width=300 height=200 controls></video>

20 <script>

21 consoleWrite("I did not crash");

22 endTest();

23 </script>

24 </body>

25 </html>

OLD	NEW