Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 689563002: Cleanup: Remove unneeded path_service.h includes. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
6 years, 1 month ago
CC:
chromium-reviews, asanka, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, benjhayden+dwatch_chromium.org, Ilya Sherman, mkwst+moarreviews-shell_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, vsevik, gavinp+disk_chromium.org, Aaron Boodman, benquan, stevenjb+watch_chromium.org, lcwu+watch_chromium.org, chromoting-reviews_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, aandrey+blink_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, devtools-reviews_chromium.org, kalyank, tzik, creis+watch_chromium.org, dyu1, jshin+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dsinclair+watch_chromium.org, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, gunsch+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, plundblad+watch_chromium.org, tfarina, mcasas+watch_chromium.org, yurys, aboxhall+watch_chromium.org, paulirish+reviews_chromium.org, Dane Wallinga, dtseng+watch_chromium.org, wfh+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, darin (slow to review), wjia+watch_chromium.org, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded path_service.h includes. Committed: https://crrev.com/27bf1c27bf02037ab7c32f2b8b179178aeb04cba Cr-Commit-Position: refs/heads/master@{#303095}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -68 lines) Patch
M ash/test/test_suite.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/android/cast_window_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/browser/url_request_context_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/app_mode/kiosk_oem_manifest_parser_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/system/statistics_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_dll.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/bookmarks/browser/bookmark_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/history/core/browser/url_database_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_broker_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_file_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/policy_loader_mac.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/signin/core/browser/webdata/token_service_table_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/translate/content/browser/data_file_browser_cld_data_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/url_fixer/url_fixer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/visitedlink/browser/visitedlink_master.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/visitedlink/test/visitedlink_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/android_hit_testing_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/save_package_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/webrtc_internals.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/plugin_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/safe_util_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/shared_worker/worker_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/tracing/trace_uploader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_audio_processor_options.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/app/shell_main_delegate_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/content_test_launcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_protocols.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/guest_view/test_guest_view_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/media_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/h264_parser_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/formats/mp2t/es_parser_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/network_context.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/base/filename_util_internal.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/cert_test_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/cert_test_util_nss.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/test/spawned_test_server/local_test_server_win.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/tld_cleanup/tld_cleanup_util_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/host/desktop_session_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/json_host_config_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/win/elevated_controller.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/fileapi/external_mount_points.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_implementation_android.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Lei Zhang
Looking for a rubber stamp.
6 years, 1 month ago (2014-11-04 01:57:35 UTC) #2
brettw
lgtm
6 years, 1 month ago (2014-11-04 03:35:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689563002/20001
6 years, 1 month ago (2014-11-04 03:50:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/21959)
6 years, 1 month ago (2014-11-04 03:56:49 UTC) #7
Lei Zhang
6 years, 1 month ago (2014-11-04 07:31:22 UTC) #9
gauravsh
lgtm for chromeos/network
6 years, 1 month ago (2014-11-06 19:46:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689563002/40001
6 years, 1 month ago (2014-11-06 19:58:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-06 21:55:58 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 21:56:39 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/27bf1c27bf02037ab7c32f2b8b179178aeb04cba
Cr-Commit-Position: refs/heads/master@{#303095}

Powered by Google App Engine
This is Rietveld 408576698