Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Unified Diff: Source/core/frame/PinchViewport.cpp

Issue 689543004: Make scrollbars in pinch viewport invisible until compositor makes them visible. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/PinchViewport.cpp
diff --git a/Source/core/frame/PinchViewport.cpp b/Source/core/frame/PinchViewport.cpp
index ca2d0d8688441e3e7dbe6c2192cf859602751c7b..f8e5d750ed2618dcd4b73133bd67465b31d70bef 100644
--- a/Source/core/frame/PinchViewport.cpp
+++ b/Source/core/frame/PinchViewport.cpp
@@ -308,6 +308,11 @@ void PinchViewport::setupScrollbar(WebScrollbar::Orientation orientation)
webScrollbarLayer = coordinator->createSolidColorScrollbarLayer(webcoreOrientation, thumbThickness, scrollbarMargin, false);
webScrollbarLayer->setClipLayer(m_innerViewportContainerLayer->platformLayer());
+
+ // The compositor will control the scrollbar's visibility. Set to invisible by defualt
+ // so scrollbars don't show up in layout tests.
+ webScrollbarLayer->layer()->setOpacity(0);
gmorrita 2014/10/30 18:48:47 Apparently having some API on WebScrollbarLayer lo
+
scrollbarGraphicsLayer->setContentsToPlatformLayer(webScrollbarLayer->layer());
scrollbarGraphicsLayer->setDrawsContent(false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698