Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 6895001: [cryptohome] make guest-mode homedir mount with -rwx------ (Closed)

Created:
8 years, 4 months ago by Chris Masone
Modified:
8 years, 3 months ago
Reviewers:
jimhebert, Will Drewry
CC:
chromium-os-reviews_chromium.org, gauravsh
Visibility:
Public.

Description

[cryptohome] make guest-mode homedir mount with -rwx------ BUG=chromium-os:13173 TEST=unit tests, manual: ls -ald /home/chronos/user -> drwx------ 10 chronos chronos 500 Apr 21 14:26 /home/chronos/user/ Change-Id: Ifd60b6c31e773d55d334a6f6c58565c2c64365b8 R=jimhebert@chromium.org Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ad07f0a

Patch Set 1 #

Total comments: 2

Patch Set 2 : do it Jim's way! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mount.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Chris Masone
8 years, 4 months ago (2011-04-21 21:31:07 UTC) #1
Will Drewry
With the error cleanup, this would be good to go (with some optional nits). Thanks! ...
8 years, 4 months ago (2011-04-21 21:42:09 UTC) #2
jimhebert
In theory this leaves a racey window of time between time-of-mount and time-of-chmod where the ...
8 years, 4 months ago (2011-04-21 21:51:59 UTC) #3
Chris Masone
Jim, that seems like a way better idea. Testing that change now. On 2011/04/21 21:51:59, ...
8 years, 4 months ago (2011-04-21 22:00:59 UTC) #4
Chris Masone
8 years, 4 months ago (2011-04-21 22:12:26 UTC) #5
jimhebert
LGTM :)
8 years, 4 months ago (2011-04-21 22:16:29 UTC) #6
Will Drewry
8 years, 4 months ago (2011-04-21 22:16:53 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698