Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 689473004: Add connection type to connection stats. (Closed)

Created:
6 years, 1 month ago by Jamie
Modified:
6 years, 1 month ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add connection type to connection stats: * Move the connection mode into the LogToServer ctor, since it never changes. * Parse log messages, since we don't have an explicit message for connection type. * Save the most-recent connection type for any channel, and send it with stats logs (we only know how to parse one connection type field, so this seems like the best we're going to get). Committed: https://crrev.com/d5121f3bfd26741b31f82e585f1641ca27e1f580 Cr-Commit-Position: refs/heads/master@{#302760}

Patch Set 1 #

Patch Set 2 : Fixed typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M remoting/webapp/crd/js/client_session.js View 6 chunks +18 lines, -9 lines 0 comments Download
M remoting/webapp/crd/js/log_to_server.js View 9 chunks +32 lines, -18 lines 0 comments Download
M remoting/webapp/crd/js/server_log_entry.js View 1 2 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie
ptal
6 years, 1 month ago (2014-11-04 22:20:20 UTC) #2
rmsousa
lgtm
6 years, 1 month ago (2014-11-05 03:18:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689473004/20001
6 years, 1 month ago (2014-11-05 06:15:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 07:40:16 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 07:41:40 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5121f3bfd26741b31f82e585f1641ca27e1f580
Cr-Commit-Position: refs/heads/master@{#302760}

Powered by Google App Engine
This is Rietveld 408576698