Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 689473002: Ignore errors from chrome.tabs.executeScript. (Closed)

Created:
6 years, 1 month ago by Anand Mistry (off Chromium)
Modified:
6 years, 1 month ago
Reviewers:
Dan Beam
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ignore errors from chrome.tabs.executeScript. BUG=427334 Committed: https://crrev.com/80f324fc8e90736ab94272ee583ede2140280246 Cr-Commit-Position: refs/heads/master@{#302227}

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/resources/hotword/page_audio_manager.js View 1 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Anand Mistry (off Chromium)
6 years, 1 month ago (2014-10-28 23:16:22 UTC) #1
Anand Mistry (off Chromium)
6 years, 1 month ago (2014-10-28 23:17:02 UTC) #3
Dan Beam
lgtm
6 years, 1 month ago (2014-10-30 22:17:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689473002/20001
6 years, 1 month ago (2014-10-30 22:36:12 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 1 month ago (2014-10-31 04:37:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689473002/20001
6 years, 1 month ago (2014-10-31 04:40:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 05:04:17 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 05:05:01 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/80f324fc8e90736ab94272ee583ede2140280246
Cr-Commit-Position: refs/heads/master@{#302227}

Powered by Google App Engine
This is Rietveld 408576698