Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 689463003: cc: Move FallbackFence implementation from GLRenderer to ResourceProvider. (Closed)

Created:
6 years, 1 month ago by reveman
Modified:
6 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@one-copy-throttling
Project:
chromium
Visibility:
Public.

Description

cc: Move FallbackFence implementation from GLRenderer to ResourceProvider. This allows us to use the same fallback fence for CopyResource implementation as the GLRenderer, which means the 1-copy rasterizer can be used even when CHROMIUM_sync_query support is missing. CHROMIUM_sync_query is expected to be supported everywhere but this is useful in rare cases where it's been blacklisted. While software compositing might be better in those cases, having the option to use hardware compositing is valuable. The frequency at which we check busy resources in the 1-copy rasterizer is also reduced to make the performance penalty of using the fallback fence less severe. BUG=406404 Committed: https://crrev.com/9bc50696509edce28d25653b19eef51b099a3781 Cr-Commit-Position: refs/heads/master@{#301878}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -51 lines) Patch
M cc/output/gl_renderer.cc View 2 chunks +2 lines, -31 lines 0 comments Download
M cc/resources/one_copy_raster_worker_pool.cc View 2 chunks +1 line, -7 lines 0 comments Download
M cc/resources/resource_provider.h View 2 chunks +25 lines, -0 lines 0 comments Download
M cc/resources/resource_provider.cc View 3 chunks +51 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
6 years, 1 month ago (2014-10-29 04:55:49 UTC) #2
piman
lgtm
6 years, 1 month ago (2014-10-29 17:27:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689463003/20001
6 years, 1 month ago (2014-10-29 17:29:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-29 18:19:29 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 18:20:09 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bc50696509edce28d25653b19eef51b099a3781
Cr-Commit-Position: refs/heads/master@{#301878}

Powered by Google App Engine
This is Rietveld 408576698