Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 689463002: NACL_WIN64 takes precedence over USE_OPENSSL. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@net-fix
Project:
chromium
Visibility:
Public.

Description

NACL_WIN64 takes precedence over USE_OPENSSL. With the BoringSSL Windows port, it is possible for Windows to have USE_OPENSSL set. The #ifdefs in symmetric_key.h should still resolve in the NACL_WIN64 direction. This fixes the crypto_nacl build target. BUG=338884 Committed: https://crrev.com/365d6967b6b9306b90cd001ff2887189a43838e3 Cr-Commit-Position: refs/heads/master@{#301870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M crypto/symmetric_key.h View 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
gyp and the header disagree on which takes precedence.
6 years, 1 month ago (2014-10-29 16:56:33 UTC) #2
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-29 17:06:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689463002/1
6 years, 1 month ago (2014-10-29 17:07:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 17:51:35 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 17:52:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/365d6967b6b9306b90cd001ff2887189a43838e3
Cr-Commit-Position: refs/heads/master@{#301870}

Powered by Google App Engine
This is Rietveld 408576698