pydir/run-llvm2ice.py - Issue 689433002: Remove IceConverter when LLVM IR is not allowed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pydir/run-llvm2ice.py

Issue 689433002: Remove IceConverter when LLVM IR is not allowed. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix problems from merging in master. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pydir/run-llvm2ice.py

diff --git a/pydir/run-llvm2ice.py b/pydir/run-llvm2ice.py

index 583d7f8eb72d26c32041d3f52942a36462f6bc5a..54849f0eeb973aedad7a8b0060f0675765de073b 100755

--- a/pydir/run-llvm2ice.py

+++ b/pydir/run-llvm2ice.py

@@ -74,7 +74,9 @@ def main():

cmd += ['--bitcode-format=pnacl']

if not args.no_local_syms:

cmd += ['--allow-local-symbol-tables']

- if not (args.llvm or args.llvm_source):

+ if args.llvm or args.llvm_source:

+ cmd += ['--build-on-read=0']

+ else:

cmd += ['--build-on-read']

Jim Stichnoth 2014/10/28 20:45:35 Maybe --build-on-read=1 for consistency/clarity?

Karl 2014/10/28 21:43:51 Done.

if args.args:

cmd += args.args

« no previous file with comments | « pydir/crosstest.py ('k') | src/llvm2ice.cpp » ('j') | src/llvm2ice.cpp » ('J')