Issue 6894045: wip - Code Review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6894045: wip (Closed)

Created:
9 years, 8 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, brettw-cc_chromium.org, pam+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

wip Try to make v8_value_converter_browsertest.cc work on Windows shared library builder. BUG= TEST=

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+176 lines, -290 lines)			Patch
chrome/browser/extensions/extension_function_dispatcher.cc	View	1 chunk	+4 lines, -7 lines	0 comments	Download
chrome/chrome_tests.gypi	View	2 chunks	+1 line, -5 lines	0 comments	Download
chrome/common/extensions/extension_messages.h	View	1 chunk	+8 lines, -15 lines	0 comments	Download
chrome/renderer/extensions/bindings_utils.h	View	3 chunks	+14 lines, -7 lines	0 comments	Download
chrome/renderer/extensions/bindings_utils.cc	View	2 chunks	+33 lines, -0 lines	0 comments	Download
chrome/renderer/extensions/event_bindings.h	View	1 chunk	+1 line, -1 line	0 comments	Download
chrome/renderer/extensions/event_bindings.cc	View	3 chunks	+6 lines, -10 lines	0 comments	Download
chrome/renderer/extensions/extension_dispatcher.h	View	4 chunks	+25 lines, -4 lines	0 comments	Download
chrome/renderer/extensions/extension_dispatcher.cc	View	6 chunks	+59 lines, -16 lines	0 comments	Download
chrome/renderer/extensions/extension_process_bindings.h	View	1 chunk	+0 lines, -34 lines	0 comments	Download
chrome/renderer/extensions/extension_process_bindings.cc	View	9 chunks	+15 lines, -183 lines	0 comments	Download
chrome/renderer/extensions/js_only_v8_extensions.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
chrome/renderer/extensions/renderer_extension_bindings.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
chrome/renderer/extensions/renderer_extension_bindings.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download