Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6894027: Initial refactoring complete

Created:
9 years, 8 months ago by Rick Campbell
Modified:
7 years, 7 months ago
Reviewers:
CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, cbentzel+watch_chromium.org, simonmorris+watch_chromium.org, idana, wez+watch_chromium.org, Raghu Simha, Paweł Hajdan Jr., dmaclach+watch_chromium.org, ncarter (slow), garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org, tim (not reviewing)
Visibility:
Public.

Description

Initial refactoring complete BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : Removed some superfluous verbosity #

Patch Set 3 : Removing factory method on AuthenticationService ... for now. #

Patch Set 4 : Fixed some tests that were broken by previous refactoring #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2837 lines, -234 lines) Patch
A chrome/browser/net/gaia/authentication_service.h View 1 chunk +202 lines, -0 lines 0 comments Download
A chrome/browser/net/gaia/authentication_service.cc View 1 chunk +261 lines, -0 lines 0 comments Download
A chrome/browser/net/gaia/authentication_service_unittest.h View 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/net/gaia/authentication_service_unittest.cc View 1 chunk +371 lines, -0 lines 0 comments Download
M chrome/browser/net/gaia/token_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/remoting/setup_flow_login_step.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/sync/signin_manager.h View 1 2 4 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/sync/signin_manager.cc View 1 2 2 chunks +31 lines, -127 lines 0 comments Download
A chrome/browser/sync/signin_manager_client_login.h View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A chrome/browser/sync/signin_manager_client_login.cc View 1 2 1 chunk +177 lines, -0 lines 0 comments Download
A chrome/browser/sync/signin_manager_oauth.h View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A chrome/browser/sync/signin_manager_oauth.cc View 1 2 1 chunk +170 lines, -0 lines 0 comments Download
M chrome/browser/sync/signin_manager_unittest.cc View 1 2 3 10 chunks +19 lines, -11 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_consumer.h View 1 chunk +46 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_consumer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_consumer_oauth.h View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_consumer_oauth.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_fetcher.h View 1 chunk +175 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_fetcher.cc View 1 chunk +163 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_fetcher_oauth.h View 1 chunk +202 lines, -0 lines 0 comments Download
A chrome/common/net/gaia/authentication_fetcher_oauth.cc View 1 chunk +444 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_consumer.h View 5 chunks +21 lines, -4 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_consumer.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.h View 10 chunks +26 lines, -27 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher.cc View 10 chunks +51 lines, -35 lines 0 comments Download
M chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc View 1 2 3 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/test/testing_profile.cc View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698