Fix rotation shortcut keys in PDF

pdf/instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/instance.h"
 
 #include <algorithm>  // for min()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 578 matching lines @@
   }
 
   if (event.GetType() == PP_INPUTEVENT_TYPE_KEYDOWN) {
     pp::KeyboardInputEvent keyboard_event(event);
     const uint32 modifier = event.GetModifiers();
     if (modifier & kDefaultKeyModifier) {
       switch (keyboard_event.GetKeyCode()) {
         case 'A':
           engine_->SelectAll();
           return true;
-      }
-    } else if (modifier & PP_INPUTEVENT_MODIFIER_CONTROLKEY) {
-      switch (keyboard_event.GetKeyCode()) {

[raymes, 2014/11/03 05:23:56]

This doesn't look right to me. kDefaultKeyModifier is different on mac and
windows so I disagree that the if-statement is the same on both.

I can see why this might be a problem on non-mac platforms though - if the ctrl
key is held down we will enter the if-block but never the else- block. I think
the right solution here is to get rid of the "else" and just have two sequential
if-statements.

         case ui::VKEY_OEM_4:
           // Left bracket.
           engine_->RotateCounterclockwise();
           return true;
         case ui::VKEY_OEM_6:
           // Right bracket.
           engine_->RotateClockwise();
           return true;
       }
     }
@@ skipping 2157 matching lines @@
   return instance_->HasScriptableMethod(name, exception);
 }
 
 pp::Var PDFScriptableObject::Call(const pp::Var& method,
                                   const std::vector<pp::Var>& args,
                                   pp::Var* exception) {
   return instance_->CallScriptableMethod(method, args, exception);
 }
 
 }  // namespace chrome_pdf