Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 689363003: Referrer Policy: Update SanitizeForRequest with new default behavior. (Closed)

Created:
6 years, 1 month ago by Mike West
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Referrer Policy: Update SanitizeForRequest with new default behavior. Currently, we'll crash when this method is called if a site sets `NoReferrerWhenDowngrade`. That seems like something worth fixing. :) BUG=431711 Committed: https://crrev.com/3b0e841aa8b7d5ca5999f4340b8fa6f73305d3d2 Cr-Commit-Position: refs/heads/master@{#303629}

Patch Set 1 #

Patch Set 2 : Forgot the flag. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M content/public/common/referrer.h View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Mike West
Jochen, WDYT?
6 years, 1 month ago (2014-11-11 10:41:06 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-11-11 10:45:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689363003/20001
6 years, 1 month ago (2014-11-11 10:49:30 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-11 12:22:44 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3b0e841aa8b7d5ca5999f4340b8fa6f73305d3d2 Cr-Commit-Position: refs/heads/master@{#303629}
6 years, 1 month ago (2014-11-11 12:24:00 UTC) #7
Mike West
6 years, 1 month ago (2014-11-11 12:42:11 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/683233003/ by mkwst@chromium.org.

The reason for reverting is: Doesn't compile on the debug bot. ?!.

Powered by Google App Engine
This is Rietveld 408576698