Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 68933007: Add CSSFontSelector::removeFontFaceRule() (Closed)

Created:
7 years, 1 month ago by Kunihiko Sakamoto
Modified:
7 years, 1 month ago
Reviewers:
tasak, dglazkov, dglazkov1
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Add CSSFontSelector::removeFontFaceRule() This allows StyleResolver to avoid resetting CSSFontSelector when styles are removed. BUG=305885 TEST=none, the new method is not used yet Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162221

Patch Set 1 #

Patch Set 2 : Avoid double hash lookups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -9 lines) Patch
M Source/core/css/CSSFontSelector.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSFontSelector.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFace.cpp View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFaceCache.h View 1 2 chunks +10 lines, -3 lines 0 comments Download
M Source/core/css/CSSSegmentedFontFaceCache.cpp View 1 3 chunks +38 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tasak
+dglazkov
7 years, 1 month ago (2013-11-15 07:30:35 UTC) #1
Kunihiko Sakamoto
Takashi and I chatted about bug 305885, and Takashi told me that being able to ...
7 years, 1 month ago (2013-11-15 07:59:36 UTC) #2
dglazkov
Interesting approach. I like it.
7 years, 1 month ago (2013-11-15 18:47:17 UTC) #3
tasak
lgtm. I like it, however I'm not familiar with FontSelector-related codes. So dglazkov, would you ...
7 years, 1 month ago (2013-11-18 08:21:17 UTC) #4
Kunihiko Sakamoto
I've brushed up the patch a bit. It's now ready for review. Dimitri, could you ...
7 years, 1 month ago (2013-11-18 10:38:46 UTC) #5
dglazkov
lgtm
7 years, 1 month ago (2013-11-18 18:04:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/68933007/70001
7 years, 1 month ago (2013-11-18 18:04:57 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 19:08:26 UTC) #8
Message was sent while issue was closed.
Change committed as 162221

Powered by Google App Engine
This is Rietveld 408576698